Two small things that could be fixed at some point
bioac in the routine below is an output (O), not an input (I).
C !INTERFACE: ==========================================================
SUBROUTINE BIO_EXPORT( PTR_PO4 ,
#ifdef ALLOW_FE
I PTR_FE,
#endif
I bioac,
I bi,bj,iMin,iMax,jMin,jMax,
I myIter,myTime,myThid)
the DIC_VARS.h defines a whole load of interesting arrays in some common blocks (e.g. COMMON /BIOTIC_NEEDS/, COMMON /CARBON_CHEM/). There are very few comments explaining what these are.
Some of these variable names could do with some cleaning up, for example:
the closely named "ak0" the carbon chemistry coefficient, and "k0" the light attenuation coefficient.
"fesedflux_pcm" and "FeIntSec" determining the iron flux from sediments (Fe_flux = fesedfluxpcm*pflux + FeIntSec) should surely be consistently named, e.g. fesedflux???.
Two small things that could be fixed at some point
bioac
in the routine below is an output (O), not an input (I).the DIC_VARS.h defines a whole load of interesting arrays in some common blocks (e.g.
COMMON /BIOTIC_NEEDS/
,COMMON /CARBON_CHEM/
). There are very few comments explaining what these are.