MITgcm / MITgcm

M.I.T General Circulation Model master code and documentation repository
http://mitgcm.org/
MIT License
334 stars 245 forks source link

pkg/dic/DIC_VARS.h and pkg/dic/bio_export.F #80

Closed christophernhill closed 6 years ago

christophernhill commented 6 years ago

Two small things that could be fixed at some point

  1. bioac in the routine below is an output (O), not an input (I).

    C !INTERFACE: ==========================================================
      SUBROUTINE BIO_EXPORT( PTR_PO4 ,
    #ifdef ALLOW_FE
     I           PTR_FE,
    #endif
     I           bioac,
     I           bi,bj,iMin,iMax,jMin,jMax,
     I           myIter,myTime,myThid)
  2. the DIC_VARS.h defines a whole load of interesting arrays in some common blocks (e.g. COMMON /BIOTIC_NEEDS/, COMMON /CARBON_CHEM/). There are very few comments explaining what these are.

seamanticscience commented 6 years ago

Some of these variable names could do with some cleaning up, for example:

stephdut commented 6 years ago

Looks great! Thank you @seamanticscience

edoddridge commented 6 years ago

Closed by #83