search

MITgcm / gcmfaces

gcmfaces is a Matlab / Octave toolbox that handles gridded earth variables in generic fashion. Read more at:
http://gcmfaces.readthedocs.io/en/latest/
MIT License
24 stars 21 forks source link

Update read_nctiles.m to use dir for recursive file search #13

Closed owang01 closed 2 years ago

owang01 commented 4 years ago

Update read_nctiles.m to use MATLAB's built-in dir for recursive file search as suggested by Hong, as well as a few other minor fixes.

gaelforget commented 3 years ago

Hi @owang01 & Hong

Sorry I totally failed to do this in a reasonable time frame... but I wanted to download all four releases to double check that new code works with all of them, and this is yet to happen six months later! Have you done such test by any chance?

In any event, I could just merge now and think later if that would be helpful?

owang01 commented 3 years ago

@gaelforget Thank you for going back to this. Although not extensively, I did test the new code for all four ECCO V4 releases (V4r1 thru V4r4) and it seems it works with all of them. I would prefer to merge it first, but it would be great if you could later do more extensive tests. I also want to point out that although the new code works with Release 3 (https://ecco.jpl.nasa.gov/drive/files/Version4/Release3), it does not work with the alternative Release 3 format (Release3_alt at https://ecco.jpl.nasa.gov/drive/files/Version4/Release3_alt). I think that is okay as the alternative format was experimental for the Python package ECCOv4-py and since then we have settled the file format to Release 4's. If there are interests in the future from the user community to use read_nctiles.m to read Release3_alt, I'll add the capability then.

gaelforget commented 2 years ago

merging and will test after -- now that I am back on a computer with a Matlab license where r1 to r4 has been downloaded.

Thanks @owang01 & @hongandyan !!