Closed lmilechin closed 5 years ago
@lmilechin: As discussed, let’s avoid adding function arguments unless we want users to worry about them. For example:
[x] a hard coded iterateOverFiles=true in process2nctiles.m seems sufficient; not sure if there are cases where false is really preferable but my guess is that such instances are probably rare. [x] for latlon1D an automated switch would make the most sense I think; latlon1D=true would used whenever possible (i.e., whenever the lon and lat arrays can be simplified to 1D vectors) and otherwise set latlon1D=false so that 2D coordinates will be used (this approach seems to be less commonly supported by external software). Seems that this automation could take place within process2nctiles.m or maybe even within write2nctiles.m to minimize the use of function arguments. [x] for subDir, dirOut, filAvailDiag in process2interp please uncomment the previous approach which should remain as the default; then add code to deal with situations that require additional attention internally (i.e., not via function arguments) and interactively (if necessary when e.g. there is doubt). For example, if availablediagnostics.log is not present where expected by default then issue warning and prompt user to specify the directory where it can be found. Also please add documentation in the help section wrt expected file locations. [-] process2nctiles.m : adding doClim as an optional argument would be a clear improvement but let’s deal with clmbnds internally (i.e., not via function arguments) using the earlier code for setting clmbnds automatically by default unless a csv file that provides clmbnds is found in dirDiags. I feel that a good name for this file could be [‘clmbnds’ fileDiags ‘.csv’] or something like that.
Am happy to provide further clarification if needed.
@lmilechin The most recent commits addressed issues listed above (except for adding a doClim argument + file but this can wait). I updated the above comment accordingly.
A couple details:
iterateOverFiles
that do not seem to apply anymore should be removedlatlon1D
should be removedA few more issues to sort out before merging:
read_nctiles.m
(user can always read climatology_bounds
separately)tim
This PR makes a few small changes to ensure output data formatted like Sample3 can be read in and processed. This includes edits that allows for data with only one time step. This includes:
process2interp.m
process2nctiles.m
write2nctiles.m