Open rabernat opened 6 years ago
To me this looks like the same list of files but in different order.
The order should not matter, since the two lists are converted to sets before comparison https://github.com/xgcm/xmitgcm/blob/13352a50c3a28c2fb036728a606ff2806f4bd139/xmitgcm/mds_store.py#L159-L164
We will have to get to the bottom of this...
all variables starting with ‘ice_’ are apparently unknown. Why is this so?
Are you using the diagnostics package to create these files? Or are they part of the "native" seaice output?
The variables starting with "ice_" are "native" thsice
variables. I choose the verification experiment global_ocean.cs32x15/tr_run.icedyn, because there is no output from the diagnostics package convoluting the file (as opposed to my first example of verification_other/offline_cheapaml)
Ok, so that is a standalone issue: xmitgcm cannot read the ice_*
variables because it doesn't know what they contain. The metadata has to be added manually, as done here for the KPP native output:
https://github.com/xgcm/xmitgcm/blob/master/xmitgcm/variables.py#L404
We would love to have a pull request from you that adds the necessary metadata.
We generally prefer the diagnostic output because it is "self describing"; xmitgcm parses available_diagnostics.log to determine everything it needs to know. This is clearly preferably to manually keeping track of the metadata within xmitgcm itself. But we want both possibilities to be supported.
Whatever is happening with the original error you described is trickier. I still don't understand it. Maybe @raphaeldussin can dig in when he has time.
Hi Ryan, so it's not really a bug, but a "feature", i.e. there is a list of "known" variables and most packages are not represented in this list. I could start adding "native" output variables to the list (e.g. of the seaice and thsice packages), but eventually this list would become as long or longer than the OrderedDict of state_variables. Is that what you want?
Is that what you want?
Thanks for providing the seaice stace variables in #96. That was a lot of work on your part! It definitely doesn't hurt to have this info in there. The only downside is that we / you are now responsible for maintaining it if it changes. For this reason, it is preferable to work with the diagnostics output.
I am still eager to resolve the original error related to the inconsistent parsing of the "expected file prefixes".
On the MITgcm mailing list, @mjlosch reported some problems parsing the files in his run directory
He then elaborated
gives
so basically all variables have the same “frequency” (a record a 72000 and at 72010), still it does not work. I tried this:
gives
but the meta files are all there (see above)
works, but only U,V,W,T,S,Eta are imported and all variables starting with ‘ice_’ are apparently unknown. Why is this so?