Google Calendar ICS is invalid

MJKWoolnough / ics

Package ics implements an encoder and decoder for iCalendar files

ISC License

5 stars 2 forks source link

Google Calendar ICS is invalid #4

Closed acomagu closed 5 years ago

acomagu commented 5 years ago

Google Calendar ICS can include ACTION:NONE line in ALARM section.

It's invalid so this library returns error(ErrMissingAlarmAction), but Google Calendar is really popular so maybe it should be accepted?

ref. https://github.com/C4ptainCrunch/ics.py/pull/143

Fortunately this issue can be avoided easily by replacing ACTION:NONE with ACTION:DISPLAY(or other action type). I don't know which is the better way to solve this, do you have any idea about this?

MJKWoolnough commented 5 years ago

I've just added support for ACTION:NONE (ab71f213aa9266c828d626d6944147db0953eed0), as well as a bunch of other proposed, but not currently standard, VALARM properties.

acomagu commented 5 years ago

Thank you for your work! :nerd_face: