MJOLNIRPackage / MJOLNIR

Neutron scattering software to be used at Multiplexing Joint Organization
Mozilla Public License 2.0
4 stars 5 forks source link

Custom matplotlib axis no longer a valid argument for plotCutQE #73

Open abehersan opened 2 years ago

abehersan commented 2 years ago

I believe this has to do with the added functionality of the created axes within MJOLNIR that renders externally generated axes incompatible when passed on as arguments to the plotting function plotCutQE.

Error traceback is as follows:

Traceback (most recent call last): File "/home/abe/Projects/PSI/Software/YbBr3_FieldDependence/camea_dispersion.py", line 27, in <module> ax_qq0_contour, _, _ = data.ybbr3_10T.plotCutQE(**qe_params) File "/home/abe/miniconda3/envs/workenv/lib/python3.10/site-packages/MJOLNIR/_tools.py", line 71, in newFunc returnval = func(*args,**kwargs) File "/home/abe/miniconda3/envs/workenv/lib/python3.10/site-packages/MJOLNIR/Data/DataSet.py", line 1025, in plotCutQE pos = ax.calculatePositionInv(HKL) AttributeError: 'AxesSubplot' object has no attribute 'calculatePositionInv'

I tested custom axes for plotCutQELine and didn't run into the issue there so it might not be a general issue. Haven't tried 1D plot cut methods yet.

abehersan commented 2 years ago
(workenv) [abe@tx1c ~]$ pip show MJOLNIR
Name: MJOLNIR
Version: 1.2.1
Jakob-Lass commented 2 years ago

Hoi Abraham

Ich habe es hoffentlich gelöst und es hochgeladen in den Develop Branch.

LG, Jakob

On Wed, 7 Sept 2022 at 17:23, abehersan @.***> wrote:

I believe this has to do with the added functionality of the created axes within MJOLNIR that renders externally generated axes incompatible when passed on as arguments to the plotting function plotCutQE.

Error traceback is as follows:

Traceback (most recent call last): File "/home/abe/Projects/PSI/Software/YbBr3_FieldDependence/camea_dispersion.py", line 27, in ax_qq0contour, , _ = data.ybbr3_10T.plotCutQE(*qe_params) File "/home/abe/miniconda3/envs/workenv/lib/python3.10/site-packages/MJOLNIR/_tools.py", line 71, in newFunc returnval = func(args,**kwargs) File "/home/abe/miniconda3/envs/workenv/lib/python3.10/site-packages/MJOLNIR/Data/DataSet.py", line 1025, in plotCutQE pos = ax.calculatePositionInv(HKL) AttributeError: 'AxesSubplot' object has no attribute 'calculatePositionInv'

I tested custom axes for plotCutQELine and didn't run into the issue there so it might not be a general issue. Haven't tried 1D plot cut methods yet.

— Reply to this email directly, view it on GitHub https://github.com/MJOLNIRPackage/MJOLNIR/issues/73, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIN3KDN6YMDYDD2QN3AHKULV5CXOFANCNFSM6AAAAAAQG4BEKU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Jakob-Lass commented 2 years ago

Solved in 32c5c0fc4ad0f53f0811358a05368cbc918ae79b by checking for presence of distance function. If not found utilize standard distance.

abehersan commented 2 years ago

attempted fix in pull req. #74 - testing for plotCut1D pending