search

MJRLegends / ExtraPlanets

A Galacticraft Addon for Minecraft
59 stars 42 forks source link

"View Bobbing" Affects Moons/Stars On Jupiter #413

Open TheRealDannyyy opened 5 years ago

TheRealDannyyy commented 5 years ago

---Issue Report---

Description of Issue

I've noticed a minor visual issue with some moons/stars, that can be seen in the skies of Jupiter. The view bobbing effect seems to affect them and make them "bobble" around while walking.

Steps to Reproduce Issue

  1. Enable "view bobbing" setting
  2. Visit Jupiter
  3. Notice moon/star bobbing around (only a few of them)

Crash log/Log (if applicable): On request if really required.

Screenshots (if applicable): On request if really required.

Version of Mod using (PLEASE DONT USE 'Latest' OR 'Newest'):

(Server is using exactly the same versions.)

Where did this bug happen: Dedicated Nitrado server with connected clients.

MJRLegends commented 5 years ago

Does it do it for moon and mars and venus?

TheRealDannyyy commented 5 years ago

From what I could see (difficult repro because of #412), the following planets/moons/stars are affected: (1 is bobbing the most and 3 the least, not sure why the intensity is different for each one.) BobbingExample

MJRLegends commented 5 years ago

Thats not what i meant by does it happen on the moon and venus and mars. I meant the dimensions not the sky. As i believe its the same code they use for there stars as i believe this is a Galacticraft bug too.

TheRealDannyyy commented 5 years ago

Sorry for the misunderstanding. I couldn't reproduce it on those planets like I can on Jupiter. It could be more subtle to the point where it isn't noticeable but I'm not sure.

Could you maybe look into the code and further identify the cause? I assume that's not a problem for you, since you know how all the stuff works. I'll re-open another issue if Extraplanets is indeed not the cause.

MJRLegends commented 5 years ago

I dont think it is the cause as ive seen people report this before. I will look at it though

TheRealDannyyy commented 5 years ago

Maybe this will help when investigating.

While landing, some planets/moons seem to be too closely "attached" to the players view. Seems like they are more like sprites, instead of static elements you can see in the sky. Although that might just be the way Minecraft works, don't know how the whole skybox system works in detail.

MJRLegends commented 4 years ago

Im not sure how to fix sorry

MJRLegends commented 4 years ago

If any one wants to make a pull request to fix please do i will be grateful