search

MJRLegends / Planet-Progression

A Galacticraft addon for Planet Research Progression
4 stars 5 forks source link

Multiple research papers consumed when stacked in telescope #43

Closed Blayyke closed 5 years ago

Blayyke commented 5 years ago

---Issue Report---

(PLEASE DONT DELETE THIS TEMPLATE, YOUR ISSUE WILL BE IGNORED AND CLOSED IF YOU DO.)

Have you checked Closed Issues (if applicable & PLEASE CHECK BEFORE POSTING): Yes

Description of Issue

Using research papers in the telescope will clear the entire slot rather than just deleting one item on research completion. Having multiple of the same type of research paper results in them all being deleted when it finishes.

Steps to Reproduce Issue

  1. Place 2 or more research papers of the same type in a telescope
  2. Wait for telescope to finish
  3. All of the research papers are gone, rather than just one

Crash log/Log (if applicable): None. Screenshots (if applicable): Not super useful but https://i.imgur.com/93MTY38.jpg, https://i.imgur.com/vsksmPi.jpg Version of Mod using (PLEASE DONT USE 'Latest' OR 'Newest'): PlanetProgression-1.12.2-0.3.1

Where did this bug happen: Single player, probably server too

Additional Information

[Any other information that may be able to help me with the problem]

MJRLegends commented 5 years ago

Are you stacking the research papers for the same planet/moon?

Blayyke commented 5 years ago

Yes, when research papers of the same planet are stacked in the telescope they all vanish when the research completes.

MJRLegends commented 5 years ago

Fairs tbh you only need one research paper for each planet or moon anyways so you shouldnt be creating 16 in the satellite controller. But yeah i will probably fix at some point but its not really a major issue

MJRLegends commented 5 years ago

If anything it acts as a trash can to remove the not needed papers since you only need one anyways

Blayyke commented 5 years ago

Threw a ton in the telescope for my group to use after I was done researching mine so they could grab and use it for themselves, wasnt expecting them to vanish but they're passively generated so it's not a huge deal. Was expecting it to just loop back when it got to 100% like they do when you put an already unlocked schem in there :+1:

MJRLegends commented 5 years ago

The telescope is unique to the player anyway so you can even do that haha.

Blayyke commented 5 years ago

Oh right, ah well not much of an issue lol. thanks anyway :P

MJRLegends commented 5 years ago

Yeah haha i will fix it though as it is a bug. Thanks for the bug report.