MKSx / Send-Audio-Plugin-BetterDiscord

Record and send audios in chat
24 stars 19 forks source link

XSS in recordingInfoPanel #8

Closed quantiom closed 4 years ago

quantiom commented 4 years ago

Issue

On line 1072, data is declared as: const data = `Recording in ${SendAudioUtil.getChannelName(type)} (${SendAudioUtil.getGuildName(type)})`; And the getChannelName / getGuildName does not sanitize the name. data is used to create the SendAudioUtil panel and is not sanitized either. If you want to test this, you can rename a guild or channel to <img src=x onerror=alert(1)> and click the record button.

Result:

Result

MKSx commented 4 years ago

Thanks, I got this last update