MKhayle / XIVComboExpanded

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
61 stars 57 forks source link

Request: Have Soul Slice/Soul Scythe be a part of their respective combos #195

Open EnixLHQ opened 1 year ago

EnixLHQ commented 1 year ago

Requesting to have Soul Slice and Soul Scythe be a part of the single-target and AoE combos, respectively, whenever Soul Gauge is <50. Additionally, the Soul Slice to Soul Scythe feature could cooperate with this so that it detects which to use based on the combo string in use.

Currently, even though Soul Slice and Soul Scythe can switch between ST and AoE forms, it is an additional button that does not have an option to be bundled with the rest of the combo strings.

kaedys commented 1 year ago

I can see why someone would want this, but it strikes me as likely to lead to a DPS loss rather than gain. If you hit a button that normally gives you 10 Soul Gauge and instead suddenly gain 50, even if that doesn't cap you, you were probably spamming that button again to hit the next combo attack and now you may overcap. Only way I think this'd be reasonable is if it also automates the Bloodstalk -> Gibbet/Gallows, and then we're into territory of the mod automating usage of positionals when you may not be expecting them to be used.

Actually, nevermind, looking at the code, it looks like that's already a combo option. If we already have automation of the Bloodstalk + Gibbet/Gallows, I see very little reason that Soul Slice/Soul Scythe couldn't be integrated. While we're at it, can also integrate Shadow of Death refreshing (obviously, that has some issue with double Enshroud windows, but if you're merging that many abilities into one key, you probably shouldn't be worrying about double Enshrouds or any similar advanced optimization concept).

MKhayle commented 1 week ago

hello! this is dawntrail time, I am still lvl 74 as a reaper, I never took the time to understand whatever this issue was about because it used words I didn't comprehend and will probably look into it once the DT issues are done with

you can remind me by the end of july if I didn't do it

MKhayle commented 1 hour ago

@kaedys could you give a second look at this because I'm not sure it's still relevant post-EW and I'm not familiar with RPR at all atm