search

MKhayle / XIVComboExpanded

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
74 stars 60 forks source link

[Bug] Can't select Deprioritize Grand Impact under Verplus Feature #342

Closed bfabe8 closed 1 month ago

bfabe8 commented 1 month ago

Describe the bug When selecting 'Deprioritize Grand Impact' under the Verstone/Verfire Plus Feature, the checkbox is not selected

To Reproduce Please try to submit as much information as possible to reproduce the behavior:

  1. Which plugin version you have
  2. Which job is affected
  3. What are your enabled combos for that job
  4. Which skill is placed in your hotbar
  5. Are you using any other XIVCombo fork? because you shouldn't

Expected behavior Should be selected

Screenshots or videos https://github.com/user-attachments/assets/85b1e679-d014-4534-9388-48c2736d738e

Additional context Add any other context about the problem here.

MKhayle commented 1 month ago

checking this out tomorrow!

kaedys commented 1 month ago

Oh, interesting. I didn't realize the description name had to be unique. >.<

MKhayle commented 1 month ago

yeah, that's... yeah.

kaedys commented 1 month ago

I guess it's not necessarily a bad restriction, identical feature names are probably inherently at risk of confusion, even with parenting, but ya, that's...oof