search

MKhayle / XIVComboExpanded

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
74 stars 60 forks source link

[Bug] Paladin's Requiescat/Imperator wouldn't turn into Blade of Honor if #136 is turned on #346

Closed HPDeskJet2540 closed 4 weeks ago

HPDeskJet2540 commented 1 month ago

Describe the bug A clear and concise description of what the bug is. In the game's default setting, Requiescat/Imperator will turn into the lvl 100 skill Blade of Honor, however if the "Requiescat Fight or Flight" is enabled, the Requiescat/Imperator wouldn't turn into Blade of Honor. To Reproduce Please try to submit as much information as possible to reproduce the behavior:

  1. Which plugin version you have: v1.5.1.9
  2. Which job is affected: Paladin
  3. What are your enabled combos for that job: Requiescat Fight or Flight Feature, Confiteor Feature, Royal Authority Combo.
  4. Which skill is placed in your hotbar: Royal Authority, Holy Spirit, Atonement, Fight or Flight
  5. Are you using any other XIVCombo fork? because you shouldn't: No

Expected behavior A clear and concise description of what you expected to happen. The Requiescat/Imperator should turn into Blade of Honor after using Blade of Valor Screenshots or videos If applicable, add screenshots/videos to help explain your problem.

Additional context Add any other context about the problem here.

kaedys commented 1 month ago

Ah, just responded to your #345 with pointing to this combo. I know this happens with the Requiescat Confiteor combo enabled. It definitely should also happen without that enabled, but just with Requiescat FoF and Confiteor Feature enabled. I can put in a quick fix for that, though I'd like to wait for your answer on #345, since that would be included, depending on your answer.

HPDeskJet2540 commented 1 month ago

Hello, I have replied in #345, thank you so much for your work!

MKhayle commented 4 weeks ago

2.0.0.0 https://github.com/MKhayle/XIVComboExpanded/commit/16215df0faef50a0a7796e33dfafc9f508d4ab56 is out, and should have fixed this issue. If it doesn't, please re-open this issue!