MKhayle / XIVComboExpanded

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
75 stars 60 forks source link

[Bug] Generation Legacy followup VPR #406

Closed ZachESN closed 1 month ago

ZachESN commented 1 month ago

the option only replaces First and Second Generation with legacies. third and fourth are not replaced

MKhayle commented 1 month ago

Hi, which Generation Legacy combo are you mentioning? The All-in-one Reawaken Feature worked perfectly fine on my end while testing, but I couldn't check myself for the Generation Legacy Feature as I am not yet VPR lvl 100. Is it that one?

masanbol commented 1 month ago

AIO works fine - i'll try out the other shortly to confirm

kaedys commented 1 month ago

I just tested the AIO, and then also separately the Generation Legacy Feature. Both work exactly as expected on the buttons noted. However, if one is using the Steel Coil feature that puts Hunter's Coil and Swiftskin's Coil onto the Fangs buttons, that one is not currently working with Third and Fourth Legacy. I have a fix ready for it, though.

masanbol commented 1 month ago

Aha, that explains why I missed it. Do those need to be exclusive?

kaedys commented 1 month ago

Nope, just need a special handling block for 3rd and 4th within the Steel Coil feature block. I've got a fix locally that I just tested and is now working as expected.

ZachESN commented 1 month ago

Awesome thanks

On Fri, Aug 9, 2024, 9:04 PM Kaedys @.***> wrote:

Nope, just need a special handling block for 3rd and 4th within the Steel Coil feature block. I've got a fix locally that I just tested and is now working as expected.

— Reply to this email directly, view it on GitHub https://github.com/MKhayle/XIVComboExpanded/issues/406#issuecomment-2278919260, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVAJFERABUD4BZIVK2EBTY3ZQVRJZAVCNFSM6AAAAABMJI7VTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYHEYTSMRWGA . You are receiving this because you authored the thread.Message ID: @.***>