MKhayle / XIVComboExpanded

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
75 stars 59 forks source link

[Request] MCH: Replace Hypercharge with Barrel Stabilizer under conditions. #423

Open fineanddandy26 opened 2 months ago

fineanddandy26 commented 2 months ago

I think it'd be useful as an Accessibility or perhaps Secret combo to replace Hypercharge with Barrel Stabilizer when Heat Gauge is less than 50 and Barrel Stabilizer is off cooldown.

fineanddandy26 commented 2 months ago

And perhaps an alternate combo in Accessibility/Secret that makes it so Barrel Stabilizer ALWAYS replaces Hypercharge when it's off cooldown.

kaedys commented 2 months ago

Would be in line with other similar features. As I commented on the GNB Bloodfest issue, though, features that replace a consumer with a 2-minute cooldown generator that's heavily tied to the burst window are, imo, both very poor features to use and borderline traps. Those cooldowns are intended to be aligned with raid buffs and other cooldowns (such as Wildfire), not just used because you hit Hypercharge and didn't have enough heat for it at the time. That's doubly the case now that Barrel Stabilizer also unlocks the extremely potent `Murica button (Full Metal Field)..

fineanddandy26 commented 2 months ago

I think it's a little different in Machinist's case. The thing about Gunbreaker that makes it very different to most builder/spender jobs is that it's only building and spending up to 3 "points" - ergo, Bloodfest is not only mandatory but extremely crucial to maximizing damage during your burst.

Hypercharge for Machinist is as well, of course, but because Heat can go all the way to 100 and you get some on every GCD, not like Gunbreaker where you only get a bullet on the last hit, I think it's a lot less likely Hypercharge becomes a "trap" button.

Either way, even if it were to be a trap button, that's why I suggested it be an accessibility feature. Even with most of the Combos enabled Machinist is still one of the highest APM jobs.

kaedys commented 2 months ago

Well, there's two things about that. One, Barrel Stabilizer doesn't even grant Heat anymore, it grants a free Hypercharge (which is fully intended to be used with Wildfire during raid buffs), and that's somewhat important, since the free Hypercharge buff has a duration and can be wasted without using it, unlike when it granted Heat directly. Second, it grants access to Full Metal Field, which is absolutely intended to be used with raid buffs. So ya, Barrel Stabilizer is still very definitely mandatory for the burst phase, especially with that 900 potency guaranteed direct crit attached.

Even with most of the Combos enabled Machinist is still one of the highest APM jobs.

Sure, but a combo that saves you one keypress every 120s, at the cost of very possibly using it at the wrong time and wasting one or even both of the benefits of it, isn't really a win in that book, imo.

fineanddandy26 commented 2 months ago

Well it would be optional so if someone's not comfortable pressing it they wouldn't enable it, right?

Also, I wasn't saying it was optional for burst phase, I'm saying the chances of it being a trap button and being used outside of burst are far less likely compared to something like Bloodfest because heat builds a lot more naturally and intuitively.

kaedys commented 2 months ago

Sure, but that's true of any of our features. Adding new ones still has to make sense.

Now, given that we have features similar to this already on other jobs, I think that bar is probably already reached, but that won't stop me from being critical of those features and seeing them as traps. Or from noting that they aren't recommended (and why) in their descriptions, for that matter... >.>

fineanddandy26 commented 2 months ago

That's very fair. And admittedly despite being probably marked as an accessibility feature I don't think a beginner would benefit. However, I still think someone competent enough at Machinist to manage their meter well would get a lot of use out of the feature, just like someone good at Bullet management can use an easily pressable Bloodfest to great effect.

kaedys commented 2 months ago

Honestly, the worry I have with these features is less that they'll be used early inadvertently, and more that players will enable them and then either not put that cooldown on their bar, or largely forget it exists, and then just use it whenever they happen to be low on resources and hit the button absentmindedly (or notice the cooldown has replaced the button). And since nearly all of those buttons now have powerful finishers attached to them, which absolutely should be and are designed to be used during raid buffs, using them just whenever is both likely to waste that finisher (if the player hasn't enabled some other combo that automates using it), and even if it's used, likely to waste a significant portion of its potential due to using it outside the party buff window.

Like if a player goes into a dungeon boss fight already with 50 heat, and is used to using it when they press Hypercharge and are low on Heat at the time, ok, they throw out Wildfire and hopefully also use Hypercharge, but Barrel Stabilizer remains unused. 30s later, they go to Hypercharge again, or notice it's replaced Hypercharge, and use it, but completely forget that Full Metal Field even exists, much less is tied to that "yay free Hypercharge" button.

That is what I mean by them being traps. They're cooldowns, meant to be used strategically with raid buffs. Granted, a decent number of casual players just don't use their cooldowns at all, and that's unfortunate. This type of feature could, in theory, help them ever so slightly (but the value of a free Hypercharge thrown in outside raid buffs is actually very small). But what would help far more is getting them to understand that literally every single job in the game has major damage cooldowns that align with a 60s or 120s interval, and that it's extremely important that those be used on the pull and as soon as they come off cooldown thereafter. Just automating the usage behind the scenes isn't really helping them.

Imagine if we had something similar for, say, Second Wind, just use it whenever it's available. Probably would improve usage on players that never use it, but would waste most of the benefit each time, and wouldn't really be helping them at all, in the short or long term.

kaedys commented 2 months ago

However, I still think someone competent enough at Machinist to manage their meter well would get a lot of use out of the feature, just like someone good at Bullet management can use an easily pressable Bloodfest to great effect.

I would argue that anyone capable of optimizing the usage of it is 1) capable of hitting it on a separate button (ok, probably, physical accessibility really is a thing), and 2) is much better served by having it on a separate button, both for tracking the cooldown and for being able to hold it in situations where it makes sense (such as holding 2-minutes for a boss about to disappear, or you're at the end of a trash pack right before a boss in a dungeon, etc).

fineanddandy26 commented 2 months ago

Honestly, the worry I have with these features is less that they'll be used early inadvertently, and more that players will enable them and then either not put that cooldown on their bar, or largely forget it exists, and then just use it whenever they happen to be low on resources and hit the button absentmindedly (or notice the cooldown has replaced the button). And since nearly all of those buttons now have powerful finishers attached to them, which absolutely should be and are designed to be used during raid buffs, using them just whenever is both likely to waste that finisher (if the player hasn't enabled some other combo that automates using it), and even if it's used, likely to waste a significant portion of its potential due to using it outside the party buff window.

Like if a player goes into a dungeon boss fight already with 50 heat, and is used to using it when they press Hypercharge and are low on Heat at the time, ok, they throw out Wildfire and hopefully also use Hypercharge, but Barrel Stabilizer remains unused. 30s later, they go to Hypercharge again, or notice it's replaced Hypercharge, and use it, but completely forget that Full Metal Field even exists, much less is tied to that "yay free Hypercharge" button.

That is what I mean by them being traps. They're cooldowns, meant to be used strategically with raid buffs. Granted, a decent number of casual players just don't use their cooldowns at all, and that's unfortunate. This type of feature could, in theory, help them ever so slightly (but the value of a free Hypercharge thrown in outside raid buffs is actually very small). But what would help far more is getting them to understand that literally every single job in the game has major damage cooldowns that align with a 60s or 120s interval, and that it's extremely important that those be used on the pull and as soon as they come off cooldown thereafter. Just automating the usage behind the scenes isn't really helping them.

Imagine if we had something similar for, say, Second Wind, just use it whenever it's available. Probably would improve usage on players that never use it, but would waste most of the benefit each time, and wouldn't really be helping them at all, in the short or long term.

That is a valid concern. I think a note of some kind that's like "Note: This is a feature primarily for intermediate players or players confident in their knowledge of this job's mechanics. If you are a beginner, we recommend not enabling it yet as it can create bad habits, and we also recommend putting the comboed skill on your hotbar for proper cooldown management."

As for the Full Metal Field part... well, if a player isn't checking to make sure all their useable abilities are on their hotbar as is, in the nicest way possible, they're probably already a "lost cause". I don't think they care about being bare minimum optimal whatsoever, so their use case wouldn't really apply here.

However, I still think someone competent enough at Machinist to manage their meter well would get a lot of use out of the feature, just like someone good at Bullet management can use an easily pressable Bloodfest to great effect.

I would argue that anyone capable of optimizing the usage of it is 1) capable of hitting it on a separate button (ok, probably, physical accessibility really is a thing), and 2) is much better served by having it on a separate button, both for tracking the cooldown and for being able to hold it in situations where it makes sense (such as holding 2-minutes for a boss about to disappear, or you're at the end of a trash pack right before a boss in a dungeon, etc).

But that's why I specified the conditions in my original post. Hypercharge for Machinist is on use BECAUSE they can rely on having Hypercharge up every 120 seconds. Machinist is far more flexible in it's use of Heat then Gunbreaker is with bullets, especially because it's ranged.

kaedys commented 2 months ago

As for the Full Metal Field part... well, if a player isn't checking to make sure all their useable abilities are on their hotbar as is, in the nicest way possible, they're probably already a "lost cause". I don't think they care about being bare minimum optimal whatsoever, so their use case wouldn't really apply here.

I'd agree with you here IF Barrel Stabilizer didn't automatically transform into Full Metal Field by default. In fact, the design of most of the DT additions is that they do not need to have independent space on your hotbar, and instead simply replace the cooldown that triggers or enables them. So not having Full Metal Field independently on your bar is both totally normal and to an extent expected. Now, personally, I do have it separately on my bar, but for many of the other DT additions, I do not (ex. both of the new oGCDs for RDM, Wind and Fire Reply for MNK, all the new followups added to healers, etc). So I don't think it's reasonable to expect that users have these new actions on their bar, when the game itself pretty well expects they won't, or is at least designed such that they do not need to and won't by default. As a key element of this, unlike other new actions, these ones are not automatically added to your hotbar when you acquired them.

But really, Full Metal Field provides way more damage contribution than a free Hypercharge, especially a free one used randomly and not aligned with buffs and Wildfire.

But that's why I specified the conditions in my original post.

I would actually argue that the conditions in your original post are more or less built to waste the cooldown, since you advocated for only replacing it if it's off cooldown and the user has less than 50 heat. Cooldowns like that are designed to be used immediately when available, excepting situations when you're intentionally holding it for something upcoming. You did address that in your immediate follow-up, but I'd advocate that's really the only form that makes sense, always using it if it is off cooldown, not just if off CD and below 50 heat. That's especially the case now that Barrel Stabilizer cannot cause you to overcap.

MKhayle commented 2 months ago

357032336-d7973900-6f04-41ad-93ca-5396aff63699 tl;dr?

fineanddandy26 commented 2 months ago

TL;DR it should be an option because it's in line with other Job Combo lists but it's a trap option for unexperienced players like Empty Bloodfest Feature on Gunbreaker.

MKhayle commented 2 months ago

accessibility with a long description it is then

kaedys commented 2 months ago

Yep, that's a pretty sufficient TLDR. I don't like the feature, I think it's a trap, but it's also not any different from the slew of other features that work exactly like this, so I guess "meh". Definitely needs a description note of why it's a bad idea, though. This is the one I've added (locally, not yet PR'd) for GNB's Bloodfest:

NOTE: Bloodfest is intended to be used as a major damage cooldown aligned with party buffs and No Mercy.  It is not recommended to use it at random simply because you're out of powder gauge.
MKhayle commented 1 month ago

I haven't forgotten this request btw, sorry for the delay, it's coming (soon tm)