[FEATURE] Miscellaneous Part 1

kaedys commented 3 months ago

(BLM) Fixed bug with Enochian Timer feature where it could try to cast Despair even if you lack the MP to do so.
(BLM) Removed the IsEnochianActive conditional for replacing Transpose and Umbral Soul, since it is always false before level 70.
(BRD) Implemented feature to also put Iron Jaws on Apex Arrow for auto-refresh, and adjusted description and naming for existing auto-Iron Jaws features.
(BRD) Implemented feature to combine Barrage with Raging Strikes.
(BRD) Implemented inverse of existing Radiant Strikes feature, which adds Radiant Finale and Radiant Encore to Battle Voice when the latter is on CD and the former is not (helps with CD management/visibility, since Radiant Finale has 10s lower CD).
(DNC) Fixed a bug where the automatic Saber Dance features for AoE were using the single target feature references instead.
(DNC) Implemented feature that replaces Tillana with Saber Dance if at 50+ Esprit, to try to reduce instances of overcapping from it (SE: FFS please make Tillana grant a free usage instead of actual gauge).
(DRG) Updated Geirskogul to Wyrmwind Thrust feature to prioritize Wyrmwind Thrust over Nastrond, since the latter has effectively no cooldown during Life of the Dragon. The priority for usage is now Geirskogal > Wyrmwind > Nastrond.
(MNK) Optimized Nadi functionality so it prioritizes using Lunar Nadi if Brotherhood is active (or under level), since it's higher potency.
(MNK) Removed the ConflictingCombos setting for Coeurl Feature and Raptor Feature with Monke Mode, since the latter only affects the Opo button. NOTE: This allows users to manually perform a Solar Nadi combo if they prefer.
(NIN) Kazematoi feature no longer conflicts with (or requires) the Aeolian Edge combo feature.
(NIN) Implemented features for putting either Forked or Fleeting Raiju on either Aeolian Edge or Armor Crush.
(NIN) Put a Trick Attack level check in for the Kassatsu Trick feature.
(RPR) Fixed bug with Automatic Soul Slice/Scythe features where the replacement would occur even when under the level where those abilities are granted.
(RPR) Implemented feature to replace Soul Scythe with Guillotine when Reaving or Enshrouded.
(SAM) Updated and simplified Iaijutsu Tsubame Single Sen feature to simply check if Iaijutsu would be replaced by Higanbana, instead of using a direct gauge check.
(SAM) Prioritize Shoha over Zanshin of both are available and enabled for replacing Shinten, since delaying Shoha is much more likely to result in wasted resources.
(SGE) Moved all of the attack-related features to a "Damage" section.
(SGE) Merged the "Rhizomata Features" and "Somethingchole Features" sections into a single "Addersgall" section.
(VPR) Implemented feature to add ALL of the Serpent's Tail, Twinfang, and Twinblood oGCDs to the main combo buttons, to avoid overwriting them by using another oGCD (I'm really bad about missing the second of the two oGCDs for Uncoiled)
(VPR) If the player has neither Honed buff, the combo buttons are left alone, rather than both being replaced with Steel Fangs/Maw.
(VPR) The replacement of Vicewinder and Vicepit with the Twincoil Feature oGCDs now only occurs if the PvP combo for Winder/Pit is also enabled.
Removed a number of if (comboTime > 0) checks, since they're strictly redundant with lastComboMove checks.
Compressed a number of conditionals, and added new lines rather than depending on line wrapping in the IDE.
Fixed a slew of lint complaints, and added some more lint ignores to the editorconfig.

Fixes #435, fixes #433, fixes #430.

MKhayle commented 3 months ago

"Part 1" 🥶

kaedys commented 3 months ago

Ya, I have larger sets of changes for GNB, DRK, and PCT that I decided to split into separate PRs.

MKhayle commented 2 months ago

I'll have time to check this out soon, sorry I've been longer than usual u_u

MKhayle commented 1 week ago

way longer than usual indeed

MKhayle / XIVComboExpanded

[FEATURE] Miscellaneous Part 1 #438