search

MKhayle / XIVComboExpanded

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
75 stars 60 forks source link

[Bug] VPR: Twin Coil Feature Replaces Vices #439

Closed Propagandist1 closed 1 month ago

Propagandist1 commented 1 month ago

Describe the bug When the Twin Coil Feature is enabled, the Vicewinder and Vicepit abilities will be replaced with Twinfang and Twinblood under certain conditions. After using Vicewinder, and then after using either Swiftskin's Coil or Hunter's Coil, all three of these abilities turn into Twinfang/Twinblood. Similarly, after using Vicepit, and then after using Swiftskin's Den or Hunter's Den, all three of these abilities turn into Twinfang/Twinblood.

To Reproduce Please try to submit as much information as possible to reproduce the behavior:

  1. Which plugin version you have: 2.0.0.12
  2. Which job is affected: VPR
  3. What are your enabled combos for that job: Just Twin Coil Feature for this test
  4. Which skill is placed in your hotbar: Vicewinder, Swiftskin's Coil, Hunter's Coil for this test
  5. Are you using any other XIVCombo fork? because you shouldn't: Nope! Expanded is all we need!

Expected behavior After using Vicewinder, and then after using either Swiftskin's Coil or Hunter's Coil, only Swiftskin's Coil and Hunter's Coil turn into Twinfang/Twinblood.

After using Vicepit, and then after using either Swiftskin's Den or Hunter's Den, only Swiftskin's Den and Hunter's Den turn into Twinfang/Twinblood.

In this way, one would still see the charges/cooldowns on Vicewinder/Vicepit while executing the combo.

Screenshots or videos

image image image image

Additional context This also happens when Steel Coil Feature is enabled in addition to the Twin Coil Feature. I wanted to have my left/right combos turn into the Coils/Dens, and then Twinfang/Twinblood when using Vicewinder. And they do! But Vicewinder changes, too. It seems like that is undesired behavior, perhaps best enabled with a sub-option.

kaedys commented 1 month ago

Thanks for the report! I actually already noticed this bug, and fixed it as part of #438 (which is awaiting review/merge/release by MKhayle)

(VPR) The replacement of Vicewinder and Vicepit with the Twincoil Feature oGCDs now only occurs if the PvP combo for Winder/Pit is also enabled.

Propagandist1 commented 1 month ago

Sweet! Thank you. Closing the issue.