[RDM] Bug: Veraero II/Verthunder II do not change into Impact (and thus Scorch and then Resolution) after using Verholy/Verflare

[kaedys]

In Endwalker, they extended the spell combo after the melee combo to the AoE spells. Veraero II and Verthunder II turn into Verholy and Verflare, respectively, while Impact turns into Scorch (level 80) followed by Resolution (level 90) after either Verholy or Verflare is cast. If using the AoE combo option, where Veraero II and Verthunder II turn into Impact when you have Dualcast, Swiftcast, or Acceleration active, they do not turn into Impact for the Scorch and Resolution casts after Verholy/Verflare.

[Grammernatzi]

    internal class RedMageAoECombo : CustomCombo
    {
        protected internal override CustomComboPreset Preset { get; } = CustomComboPreset.RedMageAoECombo;

        protected internal override uint[] ActionIDs { get; } = new[] { RDM.Veraero2, RDM.Verthunder2 };

        protected override uint Invoke(uint actionID, uint lastComboMove, float comboTime, byte level)
        {
            if (actionID == RDM.Veraero2 || actionID == RDM.Verthunder2)
            {
                if (lastComboMove == RDM.Scorch && level >= RDM.Levels.Resolution)
                    return RDM.Resolution;

                if ((lastComboMove == RDM.Verflare || lastComboMove == RDM.Verholy) && level >= RDM.Levels.Scorch)
                    return RDM.Scorch;

                if (level >= RDM.Levels.Scatter && (HasEffect(RDM.Buffs.Dualcast) || HasEffect(RDM.Buffs.Acceleration) || HasEffect(RDM.Buffs.Swiftcast) || HasEffect(RDM.Buffs.LostChainspell)))
                    return OriginalHook(RDM.Scatter);
            }

            return actionID;
        }
    }

Here is a fix for later, when he can add it.

[daemitus]

implemented in .33

On Sat, Dec 18, 2021 at 3:27 AM Adam @.***> wrote:

internal class RedMageAoECombo : CustomCombo
{
    protected internal override CustomComboPreset Preset { get; } = CustomComboPreset.RedMageAoECombo;

    protected internal override uint[] ActionIDs { get; } = new[] { RDM.Veraero2, RDM.Verthunder2 };

    protected override uint Invoke(uint actionID, uint lastComboMove, float comboTime, byte level)
    {
        if (actionID == RDM.Veraero2 || actionID == RDM.Verthunder2)
        {
            if (lastComboMove == RDM.Scorch && level >= RDM.Levels.Resolution)
                return RDM.Resolution;

            if ((lastComboMove == RDM.Verflare || lastComboMove == RDM.Verholy) && level >= RDM.Levels.Scorch)
                return RDM.Scorch;

            if (level >= RDM.Levels.Scatter && (HasEffect(RDM.Buffs.Dualcast) || HasEffect(RDM.Buffs.Acceleration) || HasEffect(RDM.Buffs.Swiftcast) || HasEffect(RDM.Buffs.LostChainspell)))
                return OriginalHook(RDM.Scatter);
        }

        return actionID;
    }
}

Here is a fix for later, when he can add it.

— Reply to this email directly, view it on GitHub https://github.com/daemitus/XIVComboPlugin/issues/50#issuecomment-997169176, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBBMQWMPTRGP4GYAVDTURRAVRANCNFSM5KKMFLYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>