search

MKuranowski / WarsawGTFS

Creates GTFS feed from ZTM Warsaw data
https://mkuran.pl/gtfs/
MIT License
34 stars 9 forks source link

remove Sielce 06, add Sielce 75, 76 to missing stops #55

Closed DomeQdev closed 4 months ago

MKuranowski commented 4 months ago

The coordinates for Sielce 75 and 76 are the same, this isn't allowed; different stops must have different positions.

DomeQdev commented 4 months ago

The coordinates for Sielce 75 and 76 are the same, this isn't allowed; different stops must have different positions.

Sielce 75 is Sielce 05, and Sielce 76 is Sielce 06, we would have to put 75 on 05 if we want it to be correct. Both 75 and 76 are exit-only, and apps don't show departures from these stops.

MKuranowski commented 4 months ago

Even if arrival-only, a lot of apps attempt to place a pin on a map and struggle with multiple pins in the exact same coordinates. Stops with exactly the same positions are disallowed.

Generally speaking, I think that ZTM has screwed up the IDs of those stops. 7x should be used for temporary stop movements, while they use it here to artificially separate arriving and departing trips - they normally use 8x for such "fake" stops.

The solution here would be to merge both 305875 and 305876 into 305805; there is some code that deals with stop merging already, maybe it could be used instead. For now though, to avoid exactly the same coordinates it's okay to spread the stops apart by a few meters.