search

ML-KULeuven / problog

ProbLog is a Probabilistic Logic Programming Language for logic programs with probabilities.
https://dtai.cs.kuleuven.be/problog/
307 stars 36 forks source link

fix: add requirements #116

Closed foxyseta closed 3 months ago

foxyseta commented 4 months ago

requirements.txt is currently empty. Because of this, pipx install problog did not add the necessary setuptools requirement to the newly created virtual environment on my machine, resulting on a runtime error on start.

foxyseta commented 3 months ago

bump @rmanhaeve

rmanhaeve commented 3 months ago

I can't accept in its current format, as it specifies too many requirements, and the versioning is too strict in my opinion. Perhaps this would be better raised as an issue in the original repository, where we can then fix it properly.

foxyseta commented 3 months ago

No problem! Would you mind pointing me at the original repository, please? I got the link to this one from the "Download" page of the Problog website.

Regarding the number of the requirements: as this is the automatically generated output of pipreqs, which just crawls the source code for "import" statements, all these packages are guaranteed to be necessary for Problog. You can reproduce this yourself. A system without any of them is unable to run Problog w/o errors, so your own setup certainly features all of them (some of them are preinstalled with some Python tools). Did you maybe mean that they are too many for a human check, too? Let me know how I can help.