ML-KULeuven / problog

ProbLog is a Probabilistic Logic Programming Language for logic programs with probabilities.
https://dtai.cs.kuleuven.be/problog/
298 stars 34 forks source link

Example 3 in Naive Bayes param learning tutorial fails with "Encountered a non-ground probabilistic clause." #50

Closed lewtds closed 2 years ago

lewtds commented 3 years ago

https://dtai.cs.kuleuven.be/problog/tutorial/learning/03_naivebayes.html

Screenshot 2020-12-14 at 0 50 20
VincentDerk commented 3 years ago

The LFI code has recently been updated to improve convergence rate.

@wenchiyang , @arcchitjain Could you have a look please? Perhaps also add these examples to the tests (both example 3 and the example at the bottom of the page).

VincentDerk commented 3 years ago

@wenchiyang Also update/fix documentation please: https://problog.readthedocs.io/en/latest/python.html#parameter-learning-lfi

60

This loop causes an error for that example, since the documentation (this and this) is not up to date. It would be good if we would accept both input formats.

VincentDerk commented 2 years ago

Should all be fixed now with v2.2.1: d6acf3e3c55133d16b98c927a03145e22258be7b