Query Regarding goal_from_shot function

ML-KULeuven / socceraction

Convert soccer event stream data to SPADL and value player actions using VAEP or xT

MIT License

579 stars 133 forks source link

Query Regarding goal_from_shot function #745

Closed yureed closed 2 weeks ago

yureed commented 2 weeks ago

Trying to use the goal_from_shot function for my Euros data from whoscored

It messes up for a lot of the different matches. It marks some shots as a goal. For instance, for Georgia vs Czechia rn, it showed me Czechia scored 2 goals. Then for Scotland vs Switzerland, it also messed up. I can go on, but I assume you get the point. I am not sure if this is an issue regarding the WhoScored data or if its this function messing up. Appreciate your help, Thank you.

probberechts commented 2 weeks ago

I think I might have just fixed this in #741.

yureed commented 2 weeks ago

Doesn't seem to work for me. I have added the latest files. Maybe I am doing something wrong? I have used this before multiple times. I used spadl to convert the actions and then at the end, i used goal_from_shot for vaep labels to finalize.

yureed commented 2 weeks ago

Update: Tried restarting multiple times after changing files. Didnt work then reinstalled, then it worked. Don't know what happened here. Thank you for your help. Sorry for any inconvenience caused.