ML-course / master

A machine learning course using Python, Jupyter Notebooks, and OpenML
796 stars 315 forks source link

Small fixes #39

Closed RoanH closed 2 years ago

RoanH commented 2 years ago

Some small fixes for a few typos I noticed as well as an image that didn't render in the html view (used the same fix I've seen you use in other notebooks). I've also reformatted the formulas in the nearest neighbors notebook mostly because I noticed the log being written as normal plain text.

(I only updated the notebooks, but the steps in production.md are still required to reflect this on the final html pages I assume)

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

RoanH commented 2 years ago

I see some interesting changes in the automatic review above. For me these changes look correct on Google collab, so I'm not quite sure what the exact issue is.

RoanH commented 2 years ago

Before I forget since the course is now over, here are some other small mistakes I wrote down but didn't get around to adding to this PR:

https://ml-course.github.io/master/notebooks/04%20-%20Model%20Selection.html#predictive-accuracy => equation broken

https://ml-course.github.io/master/notebooks/04%20-%20Model%20Selection.html#precision => equation broken

https://ml-course.github.io/master/notebooks/04%20-%20Model%20Selection.html#recall => equation broken

https://ml-course.github.io/master/notebooks/04%20-%20Model%20Selection.html#recall => equation broken

https://ml-course.github.io/master/labs/Lab%203b%20-%20Ensembles%20Solution => The hyper link at the very end of the page links to a domain that probably no longer exists and now redirects

https://ml-course.github.io/master/labs/Lab%204%20-%20Pipelines%20Solution => These are the solutions to Lab 4, but the page is titled Lab 5

https://ml-course.github.io/master/notebooks/07%20-%20Bayesian%20Learning.html#conditional-density-p-mathbf-y-x-test-mathbf-x => broken formula

https://ml-course.github.io/master/labs/Lab%205%20-%20Bayesian%20learning%20Solution#lab-6-bayesian-models-solution => Wrong title, this is not lab 6 but lab 5

https://ml-course.github.io/master/labs/Lab%206%20-%20Tutorial#label-formatting => on-hot instead of one-hot

https://ml-course.github.io/master/intro.html#lectures => link to notebook 10 is wrong (404)

https://ml-course.github.io/master/labs/Lab%207a%20-%20Convolutional%20Neural%20Networks%20Solution#lab-8-object-recognition-with-convolutional-neural-networks => The title says lab 8 but it is lab 7a

https://ml-course.github.io/master/labs/Lab%207a%20-%20Convolutional%20Neural%20Networks%20Solution#exercise-5-interpreting-misclassifications => The main misclassification is not cats and dogs, at least not here (it's cats and frogs), for me it was cats and dogs when I ran the notebook myself so this run might just be an outlier

https://ml-course.github.io/master/labs/Lab%207b%20-%20Neural%20Networks%20for%20text%20Solution#lab-9-neural-networks-for-text => titled lab 9 should be lab 7b