ML-for-B-E / nevergrad

A Python toolbox for performing gradient-free optimization
https://facebookresearch.github.io/nevergrad/
MIT License
2 stars 0 forks source link

refactoring to extract all inputs parameters for irrigation problem #17

Closed akouete-kpakpo closed 2 years ago

akouete-kpakpo commented 2 years ago

Context

The code for irrigation class lacks of cohesion.

Also there is a lot of magic numbers every where: 8 for the dimension of the problem which appears to be 2 * 4:

This problem is too specific and hardly adaptable with the current code structure (if we add 1 event in the planning for irrigation, we will have to change the dimension of the problem from 8 to 10 everywhere in the code)

Solution proposed

Refactor the code to

akouete-kpakpo commented 2 years ago

FYI @chrichri17 @Ethel2003 @abiolaTresor

akouete-kpakpo commented 2 years ago

Refactor leaf area index

Reference: https://pcse.readthedocs.io/en/stable/user_guide.html#getting-started