Error handling during `build-containers` doesn't work in all instances

ML4GW / aframev2

Detecting binary black hole mergers in LIGO with neural networks

MIT License

4 stars 14 forks source link

Error handling during `build-containers` doesn't work in all instances #193

Closed wbenoit26 closed 1 week ago

wbenoit26 commented 1 month ago

Without the git installation mentioned in #192, the plots container was failing to build. However, this doesn't raise an exception where we would expect it to, so the error doesn't get caught and we output that the plots container has been successfully built.

EthanMarx commented 1 week ago

@wbenoit26 This has been addressed right?

wbenoit26 commented 1 week ago

Correct