search

ML4GW / aframev2

Detecting binary black hole mergers in LIGO with neural networks
MIT License
5 stars 16 forks source link

Incorporate pastro into online deployment #252

Closed EthanMarx closed 1 month ago

EthanMarx commented 1 month ago

Closes #250

EthanMarx commented 1 month ago

@wbenoit26 Huge amount of file changes here b/c I added all of our local libraries as "first parties" to isort so that their imports will be grouped together. Let me try to cherry pick these commits into a separate PR

EthanMarx commented 1 month ago

@wbenoit26 think this is ready now

wbenoit26 commented 1 month ago

Looks like you need to add the p_astro lib to apptainer.def. Otherwise, yeah, this looks good

EthanMarx commented 1 month ago

@wbenoit26 Made is_sorted_by a "public" method, and added sorting tests for the generic ledger.Ledger object before i realized you already did this in test_events.py but the more tests the merrier :)

wbenoit26 commented 1 month ago

Hah, excellent, I should've put some tests there to begin with, so that's good.

Also, looks like a notebook snuck in.

wbenoit26 commented 1 month ago

Maybe we should add **/*.ipynb to .git_ignore

EthanMarx commented 1 month ago

Yeah probably a good idea - if we ever find a reason to add ipynbs we can remove it