search

ML4GW / aframev2

Detecting binary black hole mergers in LIGO with neural networks
MIT License
5 stars 16 forks source link

Incorporate `lightray` library as replacement for tuning module #264

Closed EthanMarx closed 1 month ago

EthanMarx commented 1 month ago

I stripped out our tuning scripts and generalized things a bit into lightray which is also now on pypi, the motivation being to be able to incorporate it into AMPLFI as well.

This PR removes our tuning modules in favor of using lightray

This PR also

  1. Generalizes how we find ssh keys for git-sync, looking in Path.home() / .ssh / id_rsa
  2. Fixes bug in running Tune pipeline that was introduced in the inference overhaul PR
  3. Removes charts directory and github workflow which was moved to lightray - now we use the remote chart published on that repos github for deploying the ray cluster
EthanMarx commented 1 month ago

@wbenoit26 let me know what you think - was able to get the cluster deployed but can't testing the actual tune jobs until the train container gets rebuilt and pushed with the updated environment

EthanMarx commented 1 month ago

Yeah there's probably a bug or two, but shouldn't affect the rest of the tasks