Pycbc waveform generation

ML4GW / aframev2

Detecting binary black hole mergers in LIGO with neural networks

MIT License

5 stars 16 forks source link

Pycbc waveform generation #286

Closed wbenoit26 closed 4 hours ago

wbenoit26 commented 1 week ago

This PR is a less sprawling version of #257, with hopefully fewer environment issues. Now it just:

Updates rejection.py to generate waveforms using the from_parameter functionality
Renames/rearranges some of the parameter ledger objects in a way that I think makes more sense. I tried to copy a bit from how pycbc organizes their ParameterLists

wbenoit26 commented 1 week ago

I did an end-to-end run on the previous PR's branch and everything looked good

EthanMarx commented 5 hours ago

Looks good - will approve, but not sure why the online container stopped building

wbenoit26 commented 4 hours ago

Yeah, that's a little concerning to me. Both it and the data container seem to fail to build periodically due to ligo-segments, but only as part of this workflow, never locally. Let's keep an eye on it, see if it continues to happen in future PRs