ML4GW / amplfi

Performing parameter estimation on gravitational wave data with machine learning
MIT License
7 stars 8 forks source link

add feature to oversample projection parameters #122

Open deepchatterjeeligo opened 1 month ago

deepchatterjeeligo commented 1 month ago

After this patch, the waveform generator will have the ability to oversample dec, phi, psi by a factor >= 1, so that the effective batch size is batch_size * oversampling_factor.

deepchatterjeeligo commented 1 month ago

125 to be considered first.

ravioli1369 commented 3 weeks ago

I feel the effective batch_size = batch_size * oversampling_factor should be made a bit clearer in the config, maybe oversampling_factor can be a param just right below batch_size, with a comment that explains it, or the batch_size can stay the same, and internally batch_size//oversampling_factor waveforms would be generated, then oversampled (this also should include a comment next to batch_size)