MLB-LED-Scoreboard / mlb-led-scoreboard

An LED scoreboard for Major League Baseball :baseball:
GNU General Public License v3.0
590 stars 105 forks source link

Seeing shortened team names with RHE off #387

Closed twfarley closed 1 year ago

twfarley commented 2 years ago
   "runs": {
      "runs_hits_errors": {
        "show": false,
        "compress_digits": false,
        "spacing": 3
      },  

I'm still seeing shortened team names with this disabled.

WardBrian commented 2 years ago

Do you have "full_team_names": false, in config.json?

twfarley commented 2 years ago

No, it's set to true.

twfarley commented 2 years ago

and in coords file

    "runs": {
      "runs_hits_errors": {
        "show": false,
        "compress_digits": false,
        "spacing": 3
      }, 
ty-porter commented 1 year ago

This can be repro'd by always setting runs to > 9 in data/scoreboard/team.py while a game is ongoing

class Team:
    def __init__(self, abbrev, runs, name, hits, errors):
        self.abbrev = abbrev
        self.runs = 10 
        self.name = name
        self.hits = hits
        self.errors = errors
twfarley commented 1 year ago

I didn't have "short_team_names_for_runs_hits": true, I my config file...

No longer reproducing after adding it. /facepalm

WardBrian commented 1 year ago

I think we can close this in favor of #422 then