search

MLB-LED-Scoreboard / mlb-led-scoreboard

An LED scoreboard for Major League Baseball :baseball:
GNU General Public License v3.0
582 stars 105 forks source link

Fix misaligned characters in 4x6 font #428

Closed ty-porter closed 1 year ago

ty-porter commented 1 year ago

Addresses #416

fonts

WardBrian commented 1 year ago

Is this font visually distinct from the one we currently use, besides that issue being fixed?

I ask because my pi is still running a rather old RGB matrix driver version which doesn’t yet have that issue

ty-porter commented 1 year ago

Yes, this is unfortunately a "breaking" change. Our 4x6 font was the original tom-thumb font, so this reverts to the driver's actual 4x6 font.

I added a GIF of common characters to the PR

WardBrian commented 1 year ago

Thanks! Very helpful. If not for that capital N I’d say this is a straight up improvement.

WardBrian commented 1 year ago

Could we keep a (renamed) version of the current font in the repo such that people could still use it in layouts?

ty-porter commented 1 year ago

Yeah! The great thing about it is you can always revert back to assets/fonts/patched/tom-thumb.bdf instead (since that's what the current 4x6 font actually is)