ZachPL
commented
1 year ago Changing rotation "only_preferred": true to false allows the scoreboard to start up normally without error
Closed ZachPL closed 1 year ago
ZachPL
commented
1 year ago Changing rotation "only_preferred": true to false allows the scoreboard to start up normally without error
ty-porter
commented
1 year ago Thanks for the report, it does appear that having only_preferred turned on while the preferred teams don't have live games is the source of this bug.
The linked PR should address it, will get it released ASAP once reviewed.
This issue is a
Hardware Configuration
Software Configuration
{ "preferred": { "teams": [ "Yankees" ], "divisions": [ "AL East" ] }, "news_ticker": { "team_offday": true, "always_display": false, "preferred_teams": true, "traderumors": true, "mlb_news": true, "countdowns": true, "date": true, "date_format": "%A, %B %-d", "display_no_games_live": false }, "standings": { "team_offday": false, "mlb_offday": false, "always_display": false, "display_no_games_live": false }, "rotation": { "enabled": true, "scroll_until_finished": true, "only_preferred": true, "only_live": true, "rates": { "live": 15.0, "final": 15.0, "pregame": 15.0 }, "while_preferred_team_live": { "enabled": false, "during_inning_breaks": false } }, "weather": { "apikey": "", "location": "", "metric_units": false }, "time_format": "12h", "end_of_day": "00:00", "full_team_names": true, "short_team_names_for_runs_hits": true, "pregame_weather": true, "scrolling_speed": 2, "debug": false, "demo_date": false, "preferred_game_update_delay_in_10s_of_seconds": 0 }
Expected behavior
no error
Actual behavior
Screen loops MLB logo shows this error
ERROR (10:59:39): Untrapped error in main! Traceback (most recent call last): File "/home/pi/mlb-led-scoreboard/main.py", line 168, in
main(matrix, config)
File "/home/pi/mlb-led-scoreboard/main.py", line 70, in main
data = Data(config)
File "/home/pi/mlb-led-scoreboard/data/init.py", line 23, in init
self.schedule: Schedule = Schedule(config)
File "/home/pi/mlb-led-scoreboard/data/schedule.py", line 25, in init
self.update(True)
File "/home/pi/mlb-led-scoreboard/data/schedule.py", line 61, in update
self.current_idx %= len(games)
ZeroDivisionError: integer division or modulo by zero
Additional Information
Yankees are off today, and that's the only team I have showing so i'm guessing that's part of the reason why it's broken, but on past off days it has shown the weather and news so I'm not sure what's breaking it now. Happening on multiple machines with this config