MLBZ521
commented
2 years ago Hey @macjustice.
Glad my scripts are useful to you!
I've only recently (last year or so) started seeing that used and have only really been employing it in my PkgBot project as the underlying framework it's written on does perform the validation.
That said, I do not think Python automatically validates variable types. Per the typing docs:
The Python runtime does not enforce function and variable type annotations. They can be used by third party tools such as type checkers, IDEs, linters, etc.
And testing confirms:
>>> def greeting(name: str) -> str:
... return f'Hello {name}'
...
>>> greeting("Zack")
'Hello Zack'
>>> greeting("1")
'Hello 1'
>>> greeting(1)
'Hello 1'
macjustice
I was checking out your bomgar installer scripts, which I'm extremely thankful to run across since I just spent the better part of the day reinventing this wheel badly.
As of Python 3.5, you can use type hinting to define what types a function's parameters can accept, as well as define what type a function will return.
I noticed you doing some manual input validation in
Install-BomgarJumpClient.pyand thought you could save yourself some time by changing the function definition fromdef execute_process(command, input=None):to
def execute_process(command: str, input: str = None):That would validate that anything passed to command or input be a String, and you can drop the manual input validation.
Anyhow, thanks for the awesome work, I'm giving the script a try now!