search

MLBazaar / BTB

A simple, extensible library for developing AutoML systems
https://mlbazaar.github.io/BTB/
MIT License
171 stars 41 forks source link

Integrate with Codacy #55

Open lauragustafson opened 6 years ago

lauragustafson commented 6 years ago

Integrate with Codacy for automatic analysis/commenting on PR's for code quality and style. Would reduce a lot of the work in analyzing PR's.

kveerama commented 6 years ago

@micahjsmith @csala any comments?

micahjsmith commented 6 years ago

is this a general workflow tool, or are you targeting it specifically for people who contribute new tuners?

csala commented 6 years ago

It sounds interesting as an additional quality metric, and I would say that at least it's worth a try. However, I wouldn't expect it to be able to really replace the PR reviews.

Another option would be to give something like pylint a try, but it can become a bit annoying if we don't tweak the configuration to fit our our coding style preferences (maybe this also stands for codacy!)

lauragustafson commented 6 years ago

@micahjsmith It would be a general workflow tool, but we are using it to specifically target the contributions.

@csala It wouldn't completely replace the PR reviews but would help lessen the back and forth in contribution PR's. Essentially, we could wait to review a contribution-related PR (or really any) until after codacy accepts the code. At this point the code should be in pretty good shape, so reviewing a PR would take much less work. Also the default codacy settings do require a bit of tweaking in the configuration for some of our preferences (eg turning off some of the security-related checks). I integrated it into my fork of BTB and there weren't that many settings that needed tweaking and I found the comments/reviews pretty useful.