MLBazaar / MLPrimitives

Primitives for machine learning and data science.
https://mlbazaar.github.io/MLPrimitives
MIT License
70 stars 38 forks source link

Issue 180 improve find anomalies primitive #181

Closed AlexanderGeiger closed 5 years ago

AlexanderGeiger commented 5 years ago

Addresses the changes mentioned in #180 to improve the custom.timeseries_anomalies.find_anomalies primitive

AlexanderGeiger commented 5 years ago

Just noticed that Travis uses tests/custom/test_timeseries_anomalies.py to check correctness of the code. However, I changed some of the inputs/outputs of the functions inside the Primitive and now the previously designed test-cases don't match anymore. I will update the test file as well in order to cover the new cases.

csala commented 5 years ago

Hi @AlexanderGeiger All looks good except one detail: the dosctring format.

Your current format is apparently valid, but it doesn't render right on Sphinx when the docs are generated.

Can you change it to this one instead?

Some long text that needs to be wrapped in more than one line because
it is too long to be in a single line.

Args:
    variable_name (variable_type):
        Variable description.
    variable_name (variable_type):
        Variable description that needs to be wrapped in more than one line
        because it is too long to be in a single line.
    variable_name (variable_type):
        Optional. Variable description (including default value).

Returns:
    output_type:
        Output description that needs to be wrapped in more than one line
        because it is too long to be in a single line.

The key points are: