zyteka commented 5 years ago

It looks like the code from the tutorial won't compile unless "data" is replaced with "X" in some places.

CLAassistant commented 5 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov-io commented 5 years ago

Codecov Report

Merging #204 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #204   +/-   ##
======================================
  Coverage    40.3%   40.3%           
======================================
  Files          25      25           
  Lines        1357    1357           
======================================
  Hits          547     547           
  Misses        810     810

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22c2bef...c23dda4. Read the comment docs.

csala commented 5 years ago

Hi @zyteka!

Thanks for catching and fixing this!

Before we can marge it in, would you mind signing the CLA?

csala commented 4 years ago

Hi @zyteka Just a reminder about this.

Would you mind checking and signing the CLA?

MLBazaar / MLPrimitives

Fix incorrect code samples in readme #204

Codecov Report