search

MLDERES / Py4Analytics

2 stars 11 forks source link

Hallux and Persona Notebooks #41

Closed johnstillman closed 1 year ago

johnstillman commented 1 year ago

Here is my first pull request... This should include the update to the table of contents as well.

johnstillman commented 1 year ago

Hopefully I am doing this correctly. There are two notebooks, hallux and persona, as well as, a sql file in the contrib_data folder and two new entries into the table of contents.

johnstillman commented 1 year ago

I added a couple png images to the persona notebook and some more docs into contrib_data.

MLDERES commented 1 year ago

@johnstillman , this is a great set of instructions, but I don't know that it works. For instance, 'Entities' is referenced in the hallux notebook, but it isn't defined in that notebook.

I'd like a little more information on what "here we go" means. Just a sentence which gives a little background as to what exactly is going to happen (you have the steps, but I'm not sure why these are there).

The pictures give a great understanding of what is happening in the database. Nice touch.

For those parts that are "under construction" what will they do eventually? Specifying this in the notebook will be helpful.

MLDERES commented 1 year ago

Oh, and one last thing. Since you reference a stored procedure in Hallux, it would be good to put the text of the stored procedure text in your notebook as a reference. You can put a code reference in a markdown box by surrounding with three tick symbols

 SELECT * 
 FROM People
johnstillman commented 1 year ago

Sounds good

Get Outlook for iOShttps://aka.ms/o0ukef

From: Michael Dereszynski @.> Sent: Monday, November 28, 2022 9:41:17 AM To: MLDERES/Py4Analytics @.> Cc: John Stillman @.>; Mention @.> Subject: Re: [MLDERES/Py4Analytics] Hallux and Persona Notebooks (PR #41)

Oh, and one last thing. Since you reference a stored procedure in Hallux, it would be good to put the text of the stored procedure text in your notebook as a reference. You can put a code reference in a markdown box by surrounding with three tick symbols

SELECT * FROM People

— Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMLDERES%2FPy4Analytics%2Fpull%2F41%23issuecomment-1329490328&data=05%7C01%7Cjs184%40uark.edu%7C9a0c79bc468e44b1ec6d08dad167c19d%7C79c742c4e61c4fa5be89a3cb566a80d1%7C0%7C0%7C638052540805740300%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YmQBo1aBWDb9AluM21X%2Fx3oC7d40vauyVgwTm%2FjhiV0%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA3UWEU5EQZCGKY5RC4VXAJDWKTVD3ANCNFSM6AAAAAASHINDOU&data=05%7C01%7Cjs184%40uark.edu%7C9a0c79bc468e44b1ec6d08dad167c19d%7C79c742c4e61c4fa5be89a3cb566a80d1%7C0%7C0%7C638052540805740300%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wF%2BlU5lZ6sq8Xo6vP3daD9WZNEtQL1BQXEt%2BwE7l0wE%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>