search

MLG-Fortress / CustomItemRegistry

Create your own custom items and recipes, all in-game or via configuration files!
https://dev.bukkit.org/projects/customitemrecipes
1 stars 2 forks source link

Recipe not created when inventory is closed #3

Closed dhgameryt closed 5 years ago

dhgameryt commented 5 years ago

When you created a new recipe, of a registered item, it is not saved, nor in the recipes.yml file of the plugin, it remains blank, no matter how hard you try.

I already tried deleting the plugin and removed the other plugins, but even so it always happens, I'm in 1.13 and this error makes it impossible to create any crafting, and I do not know how to create a recipe from recipes.yml in the plugin folder .

RoboMWM commented 5 years ago

Please provide steps/screenshots of steps performed to create a recipe.

RoboMWM commented 5 years ago

Also, if there is an error, please paste it.

dhgameryt commented 5 years ago

1: first, I get a diamond sword, then using /citem name, I give it a name and then I add a lore image 2: I register the object with /citem register and then I get it with /citem get sword1 image 3: use /crecipe shaped sword1 and I open the menu to create the recipe image 4: I create a recipe and press the E key to close the menu, then I try to make the item and not image image 5: I look in the plugin folder and the document is blank image

dhgameryt commented 5 years ago

try a lot of things but I do not know what the error is, in the console of the server there is no type of error or warning

dhgameryt commented 5 years ago

When I press the E key when I finish the recipe, I do not receive any message, I do not know if this is normal

RoboMWM commented 5 years ago

Ok yea you're supposed to get a message when you close the inventory. Thanks for the steps and screenshots! Will try to check things on my end.

dhgameryt commented 5 years ago

Thank you very much for answering, I hope that this problem can be solved, I repeat, I already have only this plugin on the server, well, I'll be waiting for anything.

RoboMWM commented 5 years ago

Weird, I was able to register a recipe with no issues at all. What's the output of /version and /version CustomItemRecipes?

RoboMWM commented 5 years ago

Also tested on a fresh server, no issues either.

dhgameryt commented 5 years ago

Ok, now I do.

dhgameryt commented 5 years ago

this is the server version image this is the version of the plugin image

dhgameryt commented 5 years ago

this is how it appears when I load the plugin image Try spigot and bukkit but it does not work, all in 1.13

RoboMWM commented 5 years ago

Can you try 1.13.2? It's definitely working on 1.13.2 for me. Only other thing I could think of is if you're not using a vanilla client...?

RoboMWM commented 5 years ago

Try without optifine or whatever, idk if it could be the that it's not sending an InventoryClose packet...

RoboMWM commented 5 years ago

I made sure the recipes.yml and items.yml were blank. I didn't use optifine though so idk if that may be why.

RoboMWM commented 5 years ago

Also, vanilla seems to add that "Combat" thing in the name between lore and display name.

dhgameryt commented 5 years ago

I'm going to try it on with minecraft 1.13 vanilla and then with 1.13.2 vanilla

dhgameryt commented 5 years ago

I do not get Combat in 1.13

dhgameryt commented 5 years ago

and it does not work in 1.13 vanilla

dhgameryt commented 5 years ago

Could you pass me the recipes.yml document with 1 or more recipes created so I can copy it and create my recipes?

dhgameryt commented 5 years ago

Here is a video that I made to show you how it works https://www.youtube.com/watch?v=w555xfe02Pk

RoboMWM commented 5 years ago

Just saw the video - perhaps you can try updating spigot? Maybe see if it works on Paper? https://papermc.io/downloads (just download and run paperclip.jar instead of spigot.jar)

It seems there were some updates regarding recipes but nothing that I can directly see in the commits so idk if updating spigot will do anything. But see if paper works.

Also, the "Combat" part is showing for me even with the advanced debug info. Are you sure you're using the vanilla client?

dhgameryt commented 5 years ago

yes, I use the latest version and I've tried it many times already

dhgameryt commented 5 years ago

maybe I should just try another plugin

RoboMWM commented 5 years ago

It's just not making any sense. Can you try using event debug to see what events occur when you open the chest? I'd like to find out if the event actually fires. https://www.spigotmc.org/resources/eventdebug.5940/

If not I can make a debug version of this plugin but I just see no reason why it wouldn't fire.

dhgameryt commented 5 years ago

image image image image

dhgameryt commented 5 years ago

Could you enter my server and try it yourself?

RoboMWM commented 5 years ago

Sure, what's the IP? You can join my IRC channel and tell me if you don't want to publicly post it here. https://kiwiirc.com/client/irc.spi.gt/#robomwm

dhgameryt commented 5 years ago

Thank you, really thank you for all the help you have given me, I thank you and I hope you have a good life: D, finally I can give this post closed, I hope we can be good friends!

RoboMWM commented 5 years ago

Seems that spigot silently removed custom inventory holder support for most inventories, but Paper added it back in a recent 1.13.2 build https://github.com/PaperMC/Paper/blob/684bd2adbcbfbfdc14cfca5cdf5aa39cadbb4a7c/Spigot-Server-Patches/0403-Restore-custom-InventoryHolder-support.patch

If spigot doesn't do anything about this I likely will have to add in spigot compatibility myself via removing the inventoryholder check...

dhgameryt commented 1 year ago

Nostalgic