search

MLG-Fortress / ExtraHardMode

The now-official repository for the ExtraHardMode Bukkit Plugin.
http://dev.bukkit.org/bukkit-plugins/fun-hard-mode/
Other
24 stars 19 forks source link

[Remove] comment out invalid test #225

Closed LazyGon closed 1 year ago

LazyGon commented 4 years ago

PR divided #222

With PR #224 , we can become able to build this source successfully.

RoboMWM commented 4 years ago

What's wrong with this test?

LazyGon commented 4 years ago

Test class which has no @Test method is invalid and test will fail. See #224 AppVeyor check

LazyGon commented 4 years ago

Or, other valid test is needed.

LazyGon commented 4 years ago

Tests are closely related with design policy. So if you think other tests are needed, I recommend to add them yourself.

Anyway build problem should not be left. You can write test after merging this commit.

RoboMWM commented 4 years ago

Well you're updating the test suite version - you're bumping it a major version, which will almost always result in breakages. Is the breakage here too much to easily update? Or is it something else?

LazyGon commented 4 years ago

As result of some research, I have found that there is only one breakage. The breakage appears #224 AppVeyor check. After JUnit4.12, class with @RunWith and without @Test method will produce exception in test. Other test classes work as they are. (This is reproduced only in my environment. I don't know if your environment is the same.)

And, what you have to do is to write test that is fit with current main code. This may be a little tough because test code seems not to be maintained well, in my view.

Anyway, to just pass test after merging PR #224 is easy, remove @RunWith annotation or add @Test method.

P.S Do you know some other breakages by PR #224 ?