search

MLG-Fortress / ExtraHardMode

The now-official repository for the ExtraHardMode Bukkit Plugin.
http://dev.bukkit.org/bukkit-plugins/fun-hard-mode/
Other
24 stars 19 forks source link

[Change] use static method in static way #227

Closed LazyGon closed 3 years ago

LazyGon commented 4 years ago

PR divided #222

RoboMWM commented 4 years ago

why? I know the IDE says it's static but I prefer using the instance if it's there. In fact, is there any reason why it's static in the first place?

LazyGon commented 4 years ago

If there's no reason, IDE do not say to do so. This style can cause rare mistake. And, I believe this change is based on de facto standard.

This PR is not very important. So if you do not agree, you do not have to merge.

LazyGon commented 3 years ago

This PR will never be merged. I close this.

RoboMWM commented 3 years ago

I just haven't gotten around to seeing if those should really be static or not. Since this was originally BigScary's plugin (a long time ago) it's likely that these may have been his leftovers.

RoboMWM commented 3 years ago

Since I've decided to deprioritize these projects, I'm not gonna spend time checking for "static abuse" stuff, so I guess this PR is fine.