search

MLG-Fortress / ExtraHardMode

The now-official repository for the ExtraHardMode Bukkit Plugin.
http://dev.bukkit.org/bukkit-plugins/fun-hard-mode/
Other
24 stars 19 forks source link

Fixed buckets of fish not being included in water evaporation. #248

Closed QuantumToasted closed 3 years ago

QuantumToasted commented 3 years ago

This fixes #247 because I realized how painfully easy this was likely to fix. This may likely need to be updated again if Mojang ever decides to add more buckets of fish, but I would guess it would be unlikely given how long fishing has been in.

*Note: my Java is very rusty so I'm not sure of best practices. I assigned the materials to a variable before the if because I assumed every get() would see a 1ns performance hit. I'm just used to doing it like that in C#.

RoboMWM commented 3 years ago

dispensers sure, but I think empty is covered, you just changed it from a bucket whitelist to a blacklist?

RoboMWM commented 3 years ago

also see https://github.com/MLG-Fortress/ExtraHardMode/pull/232/files