MLG-Fortress / ExtraHardMode

The now-official repository for the ExtraHardMode Bukkit Plugin.
http://dev.bukkit.org/bukkit-plugins/fun-hard-mode/
Other
24 stars 19 forks source link

Add placeholders for weight and reformate code #278

Closed 4o3F closed 3 years ago

4o3F commented 3 years ago

Add placeholder %extrahardmode_weight% and %extrahardmode_max_weight% Also did a reformate of the whole project using the code style in assests

RoboMWM commented 3 years ago

Save code refactor for another PR. I haven't gone over the styling in this yet, if you'd like to suggest changes to such a file (if it exists? Idk if it does I never checked for one, and I'm currently only familiar with intellij's .editorconfig - albeit I'm open to any other ways to communicate convention)

4o3F commented 3 years ago

I just used this file https://github.com/MLG-Fortress/ExtraHardMode/blob/34b704e56f77d34157966c56c33b21c9e6fe1a70/src/main/assets/IntelliJ%20-%20import%20for%20our%20codestyle.jar And ok, I'll make placeholder a option feature

4o3F commented 3 years ago

Done. Also I advice for a clean up of those unused competitive classes

RoboMWM commented 3 years ago

Ah, I guess the previous maintainer exported his intellij settings? Interesting.

Unless there are other recommended formats I'll get an .editorconfig in here. Ideally I want to be consistent with the existing code so it might need some adapting from the other project I currently also publish one in (GriefPrevention).

4o3F commented 3 years ago

And maybe open the discussions section for more convenient conmunications? Also is there any other means of communication? For example, Discord?

RoboMWM commented 3 years ago

yea there's an IRC channel (preferred) or dumcord. Idk if I have it in the readme.

An issue for discussing should be fine given the general activity of this plugin but I could enable that section too.

4o3F commented 3 years ago

Seems none is on readme, lol

RoboMWM commented 3 years ago

if you want to add it'd basically be https://robomwm.com/chat more or less.