search

MLG-Fortress / ExtraHardMode

The now-official repository for the ExtraHardMode Bukkit Plugin.
http://dev.bukkit.org/bukkit-plugins/fun-hard-mode/
Other
24 stars 19 forks source link

Future Paper thing #311

Closed Remski01 closed 2 years ago

Remski01 commented 2 years ago

[18:56:17 WARN]: @EventHandler method com.extrahardmode.features.AntiGrinder#onEntityDeath returns non-void type boolean. This is unsupported behavior and will no longer work in a future version of Paper. This should be reported to the developers of ExtraHardMode v3.15.0-e4f17b1 (RoboMWM,Diemex,Big_Scary)

We are currently running git-Paper-312 (MC: 1.18.2) (To note, its 21 builds outdated, but would guess they 1.19 and higher when released)

RoboMWM commented 2 years ago

why is this unsupported tho

Remski01 commented 2 years ago

No idea, cant find anything about it.

RoboMWM commented 2 years ago

if someone can ask in their dumcord that'd be nice. I don't have a problem changing it, but I still want to know why tho.

SlimeDog commented 2 years ago

Duplicate of https://github.com/MLG-Fortress/ExtraHardMode/issues/303 which reports both deprecated methods.

Remski01 commented 2 years ago

Ya, didnt saw that one. Oopsies

RoboMWM commented 2 years ago

Thank you SlimeDog, I've been slowly ploughing through all the stacked-up github notifications.

SlimeDog commented 1 year ago

Reminder that these are still reported by Paper 1.19.2.

alexchandel commented 1 year ago

why is this unsupported tho

It's probably the wrong signature of the interface. Interface implementations can't have arbitrary signatures. This return type might've been an incorrect signature that "accidentally worked."

This is supposedly fixed by #316, however there is no release, and the CI build artifact is gone.

alexchandel commented 1 year ago

Note this is a dupe of #303 (closed). @RoboMWM new release, please?

RoboMWM commented 1 year ago

I wanted to take this as an opportunity to use github releases, but alas I'm still behind on my list of priorities. I'll push out a manual release.

RoboMWM commented 1 year ago

Oh, I already pulled in something that made a new CI artifact. https://ci.appveyor.com/project/RoboMWM39862/extrahardmode/builds/46609551/artifacts

SlimeDog commented 1 year ago

Looks good on Paper 1.19.4-501. Thanks.

Note that Paper removed some of the deprecation messages.