MLGlobalHealth / phyloSI-RakaiAgeGender

Creative Commons Attribution 4.0 International
4 stars 2 forks source link

clear figs/ (previously figure_src) #15

Open melodiemonod opened 1 year ago

melodiemonod commented 1 year ago

Hi @abriz97,

There is a need to clean the scripts in figs https://github.com/MLGlobalHealth/phyloSI-RakaiAgeGender/tree/main/figs...

Do you think you could have a look at this?

In particular: 1/ We do not want to have a R reader, i.e.,

>  args_line <-  as.list(commandArgs(trailingOnly=TRUE))
print(args_line)
if(length(args_line) > 0)

without a pbs job to call it

2/ there's so much redundancy with run_stan. For example, it's just very confusing to have sensitivity analysis switchs there. If the figures created do not compare sensitivity analysis, but are for one given analysis, we should transform the script as a postprocessing script (like src/transmission_flows/postprocessing_figures). In the latter, the env from rstan is loaded so there's no need to redefined the switchs and data every time...

3/ the paths fo the function should be updated

abriz97 commented 1 year ago

Hi Melodie,

I did some changes.