MLH-Fellowship / 0.2.1-readme-dirs

A web application that generates helpful project structures for public GitHub repositories
https://project-structure-readme.netlify.app/
MIT License
1 stars 1 forks source link

Add first draft of MarkdownDisplay component #12

Closed nchaloult closed 4 years ago

nchaloult commented 4 years ago

Related to #9, but doesn't quite close it.

This PR introduces a MarkdownDisplay component on the front-end that displays the generated "tree printout" describing the directory structure of a public GitHub repo.

Implemented Functionality

Stuff Not Implemented

ralph-dev commented 4 years ago

@nchaloult What is this?

ralph-dev commented 4 years ago

Why aren't we using the existing markdown styling :P

nchaloult commented 4 years ago

@ralph-dev What do you mean by existing markdown styling?

ralph-dev commented 4 years ago

@nchaloult Like why not use the styles that we already have rather than make a new one? Or are we planning to merge this than style it with the existing style we had earlier?

nchaloult commented 4 years ago

Right, this PR doesn't have anything to do with style. I abstracted away the Markdown "tree printout" display box into its own component like we talked about doing in one of our video calls on Wednesday. This PR only introduces functionality for the new display box component.

ralph-dev commented 4 years ago

Styles always go at the bottom of the document btw

nchaloult commented 4 years ago

Styles always go at the bottom of the document btw

Oh, I didn't know that. I learned something new! 😎 The linter I've always used complains if I use things before they're defined in a file. Thanks for letting me know 😃

I'll throw a new commit onto the markdown-display-component branch that moves those styled components tomorrow morning.