search

MLH-Fellowship / 0.2.1-readme-dirs

A web application that generates helpful project structures for public GitHub repositories
https://project-structure-readme.netlify.app/
MIT License
1 stars 1 forks source link

Mark down #8

Closed ralph-dev closed 4 years ago

ralph-dev commented 4 years ago

The Initial UI structure for the MarkDown Box! image

image

(Stuck trying to align Red Dot with Text.

nchaloult commented 4 years ago

What's the red dot for? The one that you're trying to align with folder names? Is it a button?

ralph-dev commented 4 years ago

@nchaloult Great question, It's an X button so that you can delete a line if you don't want it! (Must be on right side of Line)

nchaloult commented 4 years ago

What does everyone think about abstracting away the markdown display as its own component? Right now, the MarkdownDisplay component is just a styled div. If it were its own component, we could provide a list of strings for each line to display as props, making things much more modular.

ralph-dev commented 4 years ago

I can definitely do that for Code Clean-Up later on (i was going to do it at the start but decided to optimize later haha).

It also depends on whether we want to have that as a prop or just pass it in as children :)

mohammedsahl commented 4 years ago

I think we can leave that for later if its not too crucial to the project.