MLH-Fellowship / 0.5.2-cms

Your one stop shop for maintaining and keeping track of the people you meet, and memorable details about them!
GNU General Public License v3.0
1 stars 0 forks source link

DB is initalized #21

Closed ebonnecab closed 4 years ago

ebonnecab commented 4 years ago

I added the code for the database schema in SQL and also created the routes for logging in, logging out, and registering in the auth file. I believe all you need to do is define the templates and that should work. I held off on creating routes for the contacts bc I am not sure what views you will be using. I also left out the social media links this version because in SQL I think we would need to create a separate table vs an array. I'm going to get help with that but you can add in everything else so far. here is the link for the Flask Tutorial I have been following. Feel free to reference it or ask me questions if anything is confusing.

amy-lei commented 4 years ago

Looks good to me! This looks good. Question though, this means that we’re doing our own authentication, not using an api like google sign in or twitter or Facebook correct? And it will all be through our SQLite database instead?

Hmm yeah this would be something good to look into. I've used google auth before, but I've never implemented my own authentication. Also, moving forward, since we're aiming to have flask only serve API endpoints, letting react handle the rest, auth.py might need to be implemented differently. As in it receives a request and returns whether the login is valid or not rather than render a different template.

But this is a good starting point! I'm going to approve for now so that we have the db set up.