search

MLH-Fellowship / FellowshipWrapup

A showcase of all your work done during the MLH Fellowship
MIT License
6 stars 0 forks source link

Update Template #17

Closed kartikcho closed 4 years ago

kartikcho commented 4 years ago

Added 2 new components to display comparison data,

image

image

Also, added a basic footer that uses custom graphics for the fellowship logo,

image

Will open a follow up PR soon with individual React components.

IamCathal commented 4 years ago

I was unable to get a query through the graphQL api that got the members of someone's team so we can't get their PRs or any of their stats apart from the actual person we're searching for

IamCathal commented 4 years ago

Also maybe comparing yourself to others wouldn't be the best thing if you aren't better than them in terms of the stats of PRs merged etc

kartikcho commented 4 years ago

It's not a competition so I'm not sure how this would be perceived by the end user but we could come up with another tracker to use in place of it. Do you have any ideas @IamCathal @sebastiancrossa @gmelodie ?

gmelodie commented 4 years ago

Yeah same, I think comparing wouldn't be the best experience, especially if you have less PRs merged than your pod mates (which we all know doesn't say anything about how much work you actually did).