search

MLH-Fellowship / SocioMark

A social media platform that lets you upload images and secures them by embedding a personalised hash.
https://sociomark.netlify.app
MIT License
16 stars 8 forks source link

allow users to edit post #119

Closed suhanichawla closed 3 years ago

suhanichawla commented 3 years ago

User can click on pencil icon in front of post description to edit it. User can click on check icon to complete editing. Relevant error and success toasts are displayed. Attaching screenshots for reference. Resolves #85

Editable description Screenshot (298)

Toast displayed Screenshot (299)

Edit icon Screenshot (300)_LI

aitikgupta commented 3 years ago

All checks fail to start because the greetings bot itself fails due to a long-known issue https://github.com/actions/first-interaction/issues/10 The best way to deal with this would be to remove the bot, since we definitely need the linter actions to do their job.

Ping @bodhisha @DebugAgrawal to make this executive decision.

suhanichawla commented 3 years ago

@suhanichawla Thanks for checking out the issues. PR looks good..!🎉 A small suggestion from my part, currently the description is editable by every user in the system (though not possible from the backend). So If you could show the edit icon only to the post owners, it would be cool..

Completely slipped my mind, fixed this now, thanks!

suhanichawla commented 3 years ago

In general, amazingg work @suhanichawla 🎉 We don't have linter checks running on this PR atm, reviewed it anyway.

(you get browny points for fixing the FastAPI endpoint)

Netlify deployed URL: https://6077ecb8193d2e000830a477--sociomark.netlify.app/ (it doesn't show up here because of the failing checks)

Committed all the indentation fixes

aitikgupta commented 3 years ago

Good news: Greetings bot is working fine now, via #120

Bad news: Why are linters not running their checks? :/

aitikgupta commented 3 years ago

@suhanichawla you're our first PR which isn't from one of the authors, and which is why we're running into so many issues with those actions. Just wanted to thank you for your patience, we'll try to fix those soon. :)

aitikgupta commented 3 years ago

@suhanichawla can you rebase to main? Linters oughta be running now. (also the merge conflict)

aitikgupta commented 3 years ago

@suhanichawla thanks for your contribution! (and for the patience handling the linters :p)