search

MLH-Fellowship / babel-sandbox

Babel repl-like codesandbox: check out link =>
https://codesandbox.io/s/github/babel/sandboxes
MIT License
6 stars 3 forks source link

Allow saving without custom plugin #96

Closed ianjennings closed 4 years ago

ianjennings commented 4 years ago

Right now we need to have a custom plugin before any of the server functions work. We shouldn't have to have a custom plugin on the client to save.

image

@garrettluu says:

figured it out! this bug ONLY happens when we have no custom plugin so it probably does something weird when trying to encode an empty string

See #93.

garrettluu commented 4 years ago

I believe this is an issue with how REPLState encodes and decodes empty strings; the backend should already be able to handle this. As you mentioned this morning, we can modify REPLState to store raw strings instead of base64 encoding and it will probably fix this issue