MLH-Fellowship / explorer-portfolio-batch2

Jekyll portfolio website template to showcase your work using GitHub Pages
https://mlh-fellowship.github.io/portfolio-template/
MIT License
46 stars 121 forks source link

Global variables for customising #10

Open wrussell1999 opened 3 years ago

wrussell1999 commented 3 years ago

At the moment, you have to do a lot of digging to customise the website to add your own flare to it.

Suggestion

Add a global CSS variable file where you can set the following:

Open to other suggestions too.

anjalisoni3655 commented 3 years ago

@wrussell1999 We can add a CSS file for that, which will be used in all the pages, the number of cards need to be dynamic right?

wrussell1999 commented 3 years ago

@anjalisoni3655 what I mean by number of cards is I'm using a CSS grid to say how many cards across for different screen sizes. Maybe this could be changed if someone wanted less cards.

Using 1 large CSS file means some stuff will be loaded on every page that isn't needed. Not ideal. Some stuff will be the same for every page.

anjalisoni3655 commented 3 years ago

@wrussell1999 yah correct, can you explain more how you want the structure of the styling files be

wrussell1999 commented 3 years ago

@anjalisoni3655 here's an example from another Jekyll template https://github.com/mmistakes/minimal-mistakes/blob/master/_sass/minimal-mistakes/_variables.scss

LucasLobo commented 3 years ago

Is someone doing this? We could take it. @anjalisoni3655 @wrussell1999

anjalisoni3655 commented 3 years ago

Is someone doing this? We could take it. @anjalisoni3655 @wrussell1999

You can do that!